Christmas Sweater Megacommit #143

Merged

luciusbono merged 41 commits from feat-enablefvwbg into master

2018-12-20 09:38:15 -08:00

luciusbono commented

2018-12-19 11:14:28 -08:00

(Migrated from github.com)

While we don't necessarily condone the use of big unwieldy PRs, here we are with a huge one!

Note: Some of the changes in this PR will break old versions of dinobuildr.sh, so please make sure you've grabbed the latest copy of the script.

Filevault Enabled by Default

Filevault will now be enabled by default via dinbuildr! We're using the deferred enrollment option in fdesetup to enforce FileVault at login, which will kick off automatically the next time the user or tech logs in. A notification prompt will appear explaining that FileVault is about to be turned on, and a popup will appear displaying the user's FileVault recovery key for escrow.

CrashPlan 6.x Support

As we're in the process of relaunching our CrashPlan environment at Mozilla, @n3philim rewrote our CrashPlan install procedure to support the new client. Shiny!

Linting!

This project now passes flake8 and shellcheck, although we are cheating a bit with shellcheck: there are heredocs and curl'd scripts in this project, which we will be moving off of in the coming months.

travis-ci

We've hooked dinobuildr up to travis-ci to allow us to run tests / linting. Currently, we do not block on travis-ci build status but we will in the near future.

Renamed stuff that was named badly!

Things like config.py were terrible names! So we renamed lots of things so that the repo is a little easier to understand / we aren't misusing standard naming conventions (as much).

While we don't necessarily condone the use of big unwieldy PRs, here we are with a huge one! **Note:** Some of the changes in this PR will break old versions of dinobuildr.sh, so please make sure you've grabbed the latest copy of the script. # Filevault Enabled by Default Filevault will now be enabled by default via dinbuildr! We're using the deferred enrollment option in `fdesetup` to enforce FileVault at login, which will kick off automatically the next time the user or tech logs in. A notification prompt will appear explaining that FileVault is about to be turned on, and a popup will appear displaying the user's FileVault recovery key for escrow. # CrashPlan 6.x Support As we're in the process of relaunching our CrashPlan environment at Mozilla, @n3philim rewrote our CrashPlan install procedure to support the new client. Shiny! # Linting! This project now passes flake8 and shellcheck, although we are cheating a bit with shellcheck: there are heredocs and curl'd scripts in this project, which we will be moving off of in the coming months. # travis-ci We've hooked dinobuildr up to travis-ci to allow us to run tests / linting. Currently, we do not block on travis-ci build status but we will in the near future. # Renamed stuff that was named badly! Things like `config.py` were terrible names! So we renamed lots of things so that the repo is a little easier to understand / we aren't misusing standard naming conventions (as much).

n3philim (Migrated from github.com) approved these changes

2018-12-20 09:35:34 -08:00

n3philim (Migrated from github.com) left a comment

Everything looks great -- there were a couple typos in the PR comment, but I fixed them.