Bug: Adding a clean reboot to the end of the build #77

Merged

luciusbono merged 14 commits from bug-rebootchange into master

2018-01-04 15:00:15 -08:00

luciusbono commented

2018-01-04 14:42:56 -08:00

(Migrated from github.com)

Related to #39

After a lot of fiddling, we determined we cannot reliably perform a clean reboot on the system at the end of the build (post updates) within the script itself if we call the config.py script from a "helper" script, as our security team is instructing us to do. Our helper script looks like this:

#!/bin/bash

python -c "$(curl https://raw.githubusercontent.com/mozilla/dinobuildr/master/config.py)"
echo "Rebooting!"
osascript <<EOF
tell app "System Events" 
    restart
end tell
EOF

This PR also removes the second instance of softwareupdate in our update-macos.sh script, as we found that softwareupdate would download the 10.13.2 installer twice and attempt to install it twice, which was delaying the build significantly.

Related to #39 After a lot of fiddling, we determined we cannot reliably perform a clean reboot on the system at the end of the build (post updates) within the script itself if we call the `config.py` script from a "helper" script, as our security team is instructing us to do. Our helper script looks like this: ```bash #!/bin/bash python -c "$(curl https://raw.githubusercontent.com/mozilla/dinobuildr/master/config.py)" echo "Rebooting!" osascript <<EOF tell app "System Events" restart end tell EOF ``` This PR also removes the second instance of `softwareupdate` in our `update-macos.sh` script, as we found that `softwareupdate` would download the `10.13.2` installer twice and attempt to install it twice, which was delaying the build significantly.

tristanthomas (Migrated from github.com) reviewed

2018-01-04 14:59:44 -08:00

tristanthomas (Migrated from github.com) left a comment

Looks good!