Feature: Build Tests #58

New issue

Open

opened 2017-12-13 08:04:04 -08:00 by luciusbono · 2 comments

luciusbono commented

2017-12-13 08:04:04 -08:00

(Migrated from github.com)

Some rudimentary build tests would save us a lot of headaches. Build tests would make sure that any merges to master have:

branch variables set to master
File hashes all match what is in the manifest / config

Some rudimentary build tests would save us a lot of headaches. Build tests would make sure that any merges to `master` have: - [x] `branch` variables set to `master` - [ ] File hashes all match what is in the manifest / config

luciusbono commented

2018-12-13 16:48:32 -08:00

(Migrated from github.com)

We should also:

lint with shellcheck
lint with flake8 or pylint (probably flake8)

We should also: - [x] lint with shellcheck - [x] lint with flake8 or pylint (probably flake8)

luciusbono commented

2018-12-20 16:05:40 -08:00

(Migrated from github.com)

Making progress here!
https://travis-ci.org/mozilla/dinobuildr

And as of mozilla/dinobuildr@ee8269a5b0 we pass flake8 and shellcheck. Keeping this open since we haven't written any real tests yet.

Making progress here! https://travis-ci.org/mozilla/dinobuildr And as of https://github.com/mozilla/dinobuildr/commit/ee8269a5b0e76d5ba6281e129ff180e81efc3ea8 we pass flake8 and shellcheck. Keeping this open since we haven't written any real tests yet.