Update firefox-bookmarks.sh, add Zoom, remove Vidyo #160

Merged

n3philim merged 23 commits from upd8-vidyo2zoom into master

2019-05-09 13:43:28 -07:00

n3philim commented

2019-05-07 15:51:29 -07:00

(Migrated from github.com)

Switching out the old Vidyo bookmark to sso.mozilla.com

Deep Dive

This started as a basic update but ended up spiraling into bigger changes.

Added PKG support

Apparently this never got done and we hadn't previously needed it. We supported pkgs in LFS, but not pkgs pulled down from the internet.

Fixed stderr / stdout for PKG, DMG and Mobileconfig

This apparently had been broken all along. The fix is a little hacky, but time pressure. We'll now exit on installation errors.

Set the hostname properly

mozilla/dinobuildr@1f48dfe240/resources/set-computername.sh (L30)

You need all three!

Updated our standard bookmark suite more significantly

Spring cleaning! Pass one, waiting on more input from the service desk team

Swapped Vidyo for Zoom

removed old Vidyo app, added Zoom instead, updated Dock

Updated Firefox

Switching out the old Vidyo bookmark to sso.mozilla.com ## Deep Dive This started as a basic update but ended up spiraling into bigger changes. ### Added PKG support Apparently this never got done and we hadn't previously needed it. We supported `pkgs` in LFS, but not `pkgs` pulled down from the internet. ### Fixed stderr / stdout for PKG, DMG and Mobileconfig This apparently had been broken all along. The fix is a little hacky, but time pressure. We'll now exit on installation errors. ### Set the hostname properly https://github.com/mozilla/dinobuildr/blob/1f48dfe2403f72564d471ca149ec5a2fae5b5fe5/resources/set-computername.sh#L30 You need all three! ### Updated our standard bookmark suite more significantly Spring cleaning! Pass one, waiting on more input from the service desk team ### Swapped Vidyo for Zoom removed old Vidyo app, added Zoom instead, updated Dock ### Updated Firefox

n3philim commented

2019-05-07 16:36:23 -07:00

(Migrated from github.com)

ok. stopping for today. need to add in Zoom tomorrow.

n3philim commented

2019-05-08 12:21:52 -07:00

(Migrated from github.com)

Ok: problem is we don't have a PKG handler that doesn't involve DMGs, and the Zoom installer is just a pkg.

luciusbono commented

2019-05-08 14:14:13 -07:00

(Migrated from github.com)

@n3philim I fixed the dumb trap I left you and added pkg support and tuned a few things. I think all that's left is to add Zoom to the Dock config (and remove vidyo) mozilla/dinobuildr@6b3263277c/resources/dock-config.sh (L26)

@n3philim I fixed the dumb trap I left you and added `pkg` support and tuned a few things. I think all that's left is to add Zoom to the Dock config (and remove vidyo) https://github.com/mozilla/dinobuildr/blob/6b3263277c25e14429676174b86813f7d4b1d5db/resources/dock-config.sh#L26

luciusbono (Migrated from github.com) reviewed

2019-05-08 17:36:43 -07:00

luciusbono (Migrated from github.com) left a comment

Since I was the last person to make changes, need an r+ from @n3philim before I will approve for merge.

n3philim commented

2019-05-09 10:36:05 -07:00

(Migrated from github.com)

@luciusbono ok, just did a test build, it looks like we're good to go. wanna double-check and approve?

luciusbono (Migrated from github.com) reviewed

2019-05-09 11:19:26 -07:00

luciusbono (Migrated from github.com) left a comment

r+ looks good.
tested in a VM

r+ looks good. tested in a VM

luciusbono (Migrated from github.com) approved these changes

2019-05-09 13:39:11 -07:00

luciusbono (Migrated from github.com) left a comment

r+
For those playing along at home, I'm a fool and had to rebase and resign since I missed signing a few commits. That's why I've got my signature all over Vanessa's commits.

r+ For those playing along at home, I'm a fool and had to rebase and resign since I missed signing a few commits. That's why I've got my signature all over Vanessa's commits.